Fix step-debugging in Workerd

.changeset/silver-sheep-melt.md

@@ -0,0 +1,31 @@
+---
+'@shopify/cli-hydrogen': minor
+---
+
+Enable debugger connections by passing `--debug` flag to the `h2 dev` command:
+
+- Current default runtime (Node.js sandbox): `h2 dev --debug`.
+- New Worker runtime: `h2 dev --debug --worker-unstable`.
+
+You can then connect to the port `9229` (configurable with the new `--inspector-port` flag) to start step debugging.
+
+For example, in Chrome you can go to `chrome://inspect` and make sure the inspector port is added to the network targets. In VSCode, you can add the following to your `.vscode/launch.json`:
+
+```
+{
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "name": "Hydrogen",
+      "type": "node",
+      "request": "attach",
+      "port": 9229,
+      "cwd": "/",
+      "resolveSourceMapLocations": null,
+      "attachExistingChildren": false,
+      "autoAttachChildProcesses": false,
+      "restart": true
+    }
+  ]
+}
+```

package.json

@@ -8,6 +8,7 @@
     "ci:checks": "turbo run lint test format:check typecheck",
     "dev": "npm run dev:pkg",
     "dev:pkg": "cross-env LOCAL_DEV=true turbo dev --parallel --filter=./packages/*",
+    "dev:app": "cd templates/skeleton && cross-env LOCAL_DEV=true npm run dev",
     "preview": "turbo build --filter=./packages/* && npm run preview -w demo-store",
     "lint": "eslint --no-error-on-unmatched-pattern --ext .js,.ts,.jsx,.tsx ./packages & npm run lint -w demo-store",
     "format": "prettier --write --ignore-unknown ./packages && npm run format -w demo-store",

packages/cli/oclif.manifest.json

@@ -286,9 +286,16 @@
         "debug": {
           "name": "debug",
           "type": "boolean",
-          "description": "Attaches a Node inspector",
+          "description": "Enables inspector connections with a debugger.",
           "allowNo": false
         },
+        "inspector-port": {
+          "name": "inspector-port",
+          "type": "option",
+          "description": "Port where the inspector will be available.",
+          "multiple": false,
+          "default": 9229
+        },
         "host": {
           "name": "host",
           "type": "option",
@@ -523,6 +530,19 @@
           "char": "e",
           "description": "Specify an environment's branch name when using remote environment variables.",
           "multiple": false
+        },
+        "inspector-port": {
+          "name": "inspector-port",
+          "type": "option",
+          "description": "Port where the inspector will be available.",
+          "multiple": false,
+          "default": 9229
+        },
+        "debug": {
+          "name": "debug",
+          "type": "boolean",
+          "description": "Enables inspector connections with a debugger.",
+          "allowNo": false
         }
       },
       "args": {}

packages/cli/package.json

@@ -44,7 +44,7 @@
     "fs-extra": "^11.1.0",
     "get-port": "^7.0.0",
     "gunzip-maybe": "^1.4.2",
-    "miniflare": "3.20230918.0",
+    "miniflare": "3.20231016.0",
     "prettier": "^2.8.4",
     "semver": "^7.5.3",
     "source-map": "^0.7.4",