Fix xss vulnerability in the seo component #1839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fix XSS vulnerability
WHAT is this pull request doing?
React escapes all content within a
script
component. For JSON/LD, the script content cannot be escaped, so we have to usedangerouslySetInnerHTML
. But instead this change introduces a 3p dependencysanitize-html
to sanitize the values within the JSON/LD object. This change adds 63kb to the worker bundle.HOW to test your changes?
See internal discussion.
Post-merge steps
Checklist