Fix infinite loop on 404 page #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
liady
added a commit
that referenced
this pull request
Feb 6, 2025
<!-- How to write a good PR title: - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible --> ### WHY are these changes introduced? Fixes #191 <!-- Context about the problem that this PR is addressing. If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered. --> ### WHAT is this pull request doing? This PR: - upgrades eslint to v9 and its corresponding plugins, packages and configs - removes individual eslint from all of our packages, except `templates/skeleton` - unifies our basic lint configuation to be in the root of the monorepo (it was empty until now) - fixes our `lint-staged` script to run on the changed files - removes deprecated dependencies of remix-run lint plugin and hydrogen lint plugin (not maintained) ### The relevant files in the PR are: - **eslint.config.js** - this is the base eslint config for linting our codebase - **templates/skeleton/eslint.config.js** - this is the skeleton-specific configuration, and it can be removed by the skeleton users if they want. - the rest are (stylistic only) lint fixes I tried to find the best subset of rules so that we will be able to have even minimal linting over our codebase, but at the same time not to flood many warnings over packages that weren't linted until now. If in the future we will want to add/enable a new rule, we can do it and fix its errors. <!-- ℹ️ Delete the following for small / trivial changes --> ### HOW to test your changes? 1. `npm i && npm run lint` from the root folder 2. `npm i && npm run lint` from the `templates/skeleton` folder #### Checklist - [x] I've read the [Contributing Guidelines](https://github.com/Shopify/hydrogen/blob/main/CONTRIBUTING.md) - [x] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [x] I've added a [changeset](https://github.com/Shopify/hydrogen/blob/main/CONTRIBUTING.md#changesets) if this PR contains user-facing or noteworthy changes - [ ] I've added [tests](https://github.com/Shopify/hydrogen/blob/main/CONTRIBUTING.md#testing) to cover my changes - [ ] I've added or updated the documentation <!-- THANK YOU for your pull request! Members from the Hydrogen team will review these changes and provide feedback as soon as they are available. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.