Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overwriting customLogger #2341

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Avoid overwriting customLogger #2341

merged 2 commits into from
Jul 29, 2024

Conversation

frandiox
Copy link
Contributor

Closes #2315

@frandiox frandiox requested a review from a team July 17, 2024 04:33
@shopify Shopify
Copy link
Contributor

shopify bot commented Jul 17, 2024 •
edited
Loading

Oxygen deployed a preview of your fd-fix-custom-logger branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 17, 2024 4:34 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox merged commit a2d9acf into main Jul 29, 2024
13 checks passed
@frandiox frandiox deleted the fd-fix-custom-logger branch July 29, 2024 08:47
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blittle blittle blittle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli-hydrogen overwrites vite customLogger
2 participants
@frandiox @blittle