Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unstable re-exports from remix-oxygen and update package-lock to version 3 #2551

Merged
merged 14 commits into from
Sep 24, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Sep 19, 2024

WHY are these changes introduced?

Fixes #2554

  • We were re-exporting unstable functions that disappear in a Remix minor update
  • package-lock had a version update. This is to regenerate the package-lock.json with the new version.

WHAT is this pull request doing?

HOW to test your changes?

Run

  1. npm install
  2. npm build
  3. npm typecheck

Make sure no errors / type errors in terminal and no file changes appears.

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

This comment has been minimized.

Copy link
Contributor

shopify bot commented Sep 19, 2024

Oxygen deployed a preview of your hl-update-package-lock branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:50 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:51 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:51 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:51 PM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:51 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 4:51 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel changed the title Update package-lock Update package-lock to version 3 Sep 19, 2024
@wizardlyhel wizardlyhel changed the title Update package-lock to version 3 Remove unstable re-exports from remix-oxygen and update package-lock to version 3 Sep 20, 2024
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good to me.

@wizardlyhel wizardlyhel merged commit bb5b097 into main Sep 24, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-update-package-lock branch September 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite error while updating dependencies
2 participants