Update tailwind style tag generation #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
approved these changes
Jan 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Follow up from #2701 - Fix
failed to execute 'insertBefore' on 'Node'error during developmentWhen generating a new project with tailwind css, the tailwind style tag is being generated in the wrong place. The expected root file generation is:
export function links() { return [ - {rel: 'stylesheet', href: tailwindCss}, { rel: 'preconnect', href: 'https://cdn.shopify.com', }, { rel: 'preconnect', href: 'https://shop.app', }, {rel: 'icon', type: 'image/svg+xml', href: favicon}, ]; } ... export function Layout({children}: {children?: React.ReactNode}) { const nonce = useNonce(); const data = useRouteLoaderData<RootLoader>('root'); return ( <html lang="en"> <head> <meta charSet="utf-8" /> <meta name="viewport" content="width=device-width,initial-scale=1" /> + <link rel="stylesheet" href={tailwindCss}></link> <link rel="stylesheet" href={resetStyles}></link> <link rel="stylesheet" href={appStyles}></link>WHAT is this pull request doing?
HOW to test your changes?
In the mono repo, run
npx shopify hydrogen initand create a project with tailwind css option selected. Check theroot.tsxto ensure tailwind css is generated correctlyPost-merge steps
Checklist