Update getProductOptions to handle divergent options #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
rbshop
reviewed
Feb 11, 2025
Comment on lines
126
to
128
| return Object.assign( | ||
| {}, | ||
| ...selectedOption.map((option) => ({[option.name]: option.value})), |
There was a problem hiding this comment.
This is now going to return an Object rather than a string
There was a problem hiding this comment.
oh oops! nice catch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
getProductOptionswill fail on combined listing products with divergent options. For example, we have a parent product TV and the only common option between its child products is size of the TV.getProductOptionsfails at finding a matching encoding and mapping with the selected option.WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist