[cli] obey asset env var in build command #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
vincentezw
force-pushed
the
vez/asset-path
branch
5 times, most recently
from
cb87e36 to
15362b7
Compare
This comment has been minimized.
This comment has been minimized.
vincentezw
force-pushed
the
vez/asset-path
branch
from
15362b7 to
f09c7f8
Compare
rbshop
approved these changes
Feb 17, 2025
rbshop
reviewed
Feb 17, 2025
.changeset/thin-wombats-boil.md
Outdated
| '@shopify/cli-hydrogen': patch | ||
| --- | ||
|
|
||
| Use HYDROGEN_ASSET_BASE_URL in build command |
There was a problem hiding this comment.
This might trigger a bit of fear and uncertainty. Please can you update it to reflect that this is fixing a bug where HYDROGEN_ASSET_BASE_URL was incorrectly being ignored in that specific case
vincentezw
force-pushed
the
vez/asset-path
branch
from
f09c7f8 to
8af067c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
When merchants deploy to Oxygen with
hydrogen deploy --build-command "npx shopify hydrogen build"(which is a pattern used to allow for extra arguments to be passed to the build command), the command does not take theHYDROGEN_ASSET_BASE_URLinto account.This means
/is used as asset path.WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist