This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Refactor server type to include SSLCert #66
Closed
+27
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvinEfendi
reviewed
Jun 21, 2018
internal/ingress/types_equals.go
Outdated
| return false | ||
| } | ||
| if s1.SSLPemChecksum != s2.SSLPemChecksum { | ||
| if s1.SSLCert.PemSHA != s2.SSLCert.PemSHA { |
There was a problem hiding this comment.
I'd suggest to implement Equal function for SSLCert type and just call s1.SSLCert.Equal(s2.SSLCert) here - that would be consistent with the code base here.
ElvinEfendi
reviewed
Jun 21, 2018
|
PR has been moved upstream - kubernetes#2678 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors the server type to include the
ingress.SSLCertfield. This gives us access to the certificate, which will be used in adding dynamic certificate serving functionality (Shopify/edgescale#515).@Shopify/edgescale