Merge pull request #504 from Shopify/mangara-good-job-release-notes

Add change log entry for GoodJob support
Shopify · Sep 24, 2024 · 92237a2 · 92237a2
2 parents 3fc1ba0 + 85cebdb
commit 92237a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,9 @@
 ### Main (unreleased)
-Nil
+
+- [464](https://github.com/Shopify/job-iteration/pull/464) - Add interruption adapter for [GoodJob](https://github.com/bensheldon/good_job).
 
 ## v1.5.1 (May 29,2024)
-- [483](https://github.com/Shopify/job-iteration/pull/483) Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456)
+- [483](https://github.com/Shopify/job-iteration/pull/483) - Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456)
 
 ## v1.5.0 (May 29, 2024)
 ### Changes

diff --git a/test/integration/interruption_adapters_test.rb b/test/integration/interruption_adapters_test.rb
@@ -37,7 +37,8 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase
       require 'bundler/setup'
       require 'job-iteration'
       # The adapter for GoodJob cannot be easily tested at the moment.
-      JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS.excluding(:good_job).each do |name|
+      addapters_to_test = JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS - [:good_job]
+      addapters_to_test.each do |name|
         JobIteration::InterruptionAdapters.lookup(name)
       end
     RUBY