Refactor gemfiles #438
Merged
Refactor gemfiles #438
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have several gemfiles in which we have specific version requirements for `activejob` and `activerecord`, for use in our CI matrix. The current approach breaks on Ruby HEAD because it is detected as specifying multiple versions/sources for those gems. Instead, this refactors them to use an instance variable approach, similar to that used in Shopify/maintenance_tasks.
sambostock
commented
Nov 15, 2023
| @@ -11,6 +11,17 @@ gemspec | |||
| gem "sidekiq" | |||
| gem "resque" | |||
|
|
|||
| if defined?(@rails_gems_requirements) && @rails_gems_requirements | |||
| # We avoid the `gem "..."` syntax here so Dependabot doesn't try to update these gems. | |||
There was a problem hiding this comment.
4 tasks
|
Looks like this approach works on latest Ruby HEAD, as opposed to the previous approach which no longer works as of this writing. |
Mangara
approved these changes
Nov 15, 2023
|
Yeah, it's weird. Shopify/maintenance_tasks#496 has context on how and why they got to their rails = "rails"
gem rails, @rails_gem_requirementapproach, which I adapted. |
adrianna-chang-shopify
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several gemfiles in which we have specific version requirements for
activejobandactiverecord, for use in our CI matrix.The current approach breaks on Ruby HEAD because it is detected as specifying multiple versions/sources for those gems. Instead, this refactors them to use an instance variable approach, similar to that used in Shopify/maintenance_tasks.