Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log entry for GoodJob support #504

Merged
merged 2 commits into from
Sep 24, 2024
+5 −3
Merged

Add change log entry for GoodJob support #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93c8c31
Add change log entry for GoodJob support
Mangara Sep 23, 2024
85cebdb
Fix integration load test
Mangara Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
### Main (unreleased)
Nil

- [464](https://github.com/Shopify/job-iteration/pull/464) - Add interruption adapter for [GoodJob](https://github.com/bensheldon/good_job).

## v1.5.1 (May 29,2024)
- [483](https://github.com/Shopify/job-iteration/pull/483) Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456)
- [483](https://github.com/Shopify/job-iteration/pull/483) - Reverts [#456 Use Arel instead of String for AR Enumerator conditionals](https://github.com/Shopify/job-iteration/pull/456)

## v1.5.0 (May 29, 2024)
### Changes
Expand Down
3 changes: 2 additions & 1 deletion test/integration/interruption_adapters_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase
require 'bundler/setup'
require 'job-iteration'
# The adapter for GoodJob cannot be easily tested at the moment.
JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS.excluding(:good_job).each do |name|
addapters_to_test = JobIteration::InterruptionAdapters::BUNDLED_ADAPTERS - [:good_job]
addapters_to_test.each do |name|
JobIteration::InterruptionAdapters.lookup(name)
end
RUBY
Expand Down
Loading