This repository was archived by the owner on May 6, 2024. It is now read-only.
Improve the Github Action for testing various combinations of ruby/faraday/active[support|model] #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop support for rails < 6.0 See: https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html - setup matrix for all major/minor versions of activesupport/activemodel >= 6 -
- [`faraday-gzip`](https://rubygems.org/gems/faraday-gzip/versions/2.0.0) depends on Ruby (>= 2.6, < 4) so <= 2.5 is out the window - run tests w/ the generated gemfiles (parial copied from <https://github.com/LeipeLeon/rails_key_rotator/blob/main/.github/workflows/main.yml>)
…port|model] - ruby: 2.6, 2.7, 3.0, 3.1, 3.2 - faraday: 1.x, 2.x - activesupport/active_model: 6.0, 6.1, 7.0, 7.1 - exclude ruby 2.6 / [activesupport >= 7.0](https://rubygems.org/gems/activesupport/versions/7.0.8) b/c required ruby >= 2.7.0
|
ping @lavoiesl Do you have any feedback on this PR? or should I wait when your branch is merged w/ upstream. |
|
The general idea LGTM, but I haven't reviewed in details Since this PR doesn't add any functionality that would be a blocker for Shopify development, I would suggest only opening a PR upstream. |
lavoiesl
force-pushed
the
seb-faraday-2.x
branch
5 times, most recently
from
26f873f to
1db00ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty to update the Github action to improve the tests
Also made these decisions:
drop support for rails < 6.0. It's no longer maintained.
See: https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
setup appraisals for all major/minor versions of active[support|model] >= 6
test w/ faraday 1.x & 2.x on various ruby's
faraday-gzipdepends on Ruby (>= 2.6, < 4) so <= 2.5 is out the windowwhen ruby test passes run all combinations of ruby/faraday/active[support|model]
b/c required ruby >= 2.7.0
Note: The github action is partial copied from https://github.com/LeipeLeon/rails_key_rotator/blob/main/.github/workflows/main.yml