Optimize chance of users reading error messages take 2 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Sharma <aditya.sharma@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened in place of #913
In my opinion, we should reconsider #913 and merge these changes.
Most of the support requests we receive related to krane deploy failures can be resolved by simply scrolling up to view the actual error. However, developers often overlook logs, and this minor UX adjustment (displaying errors at the bottom instead of in the middle) could make a notable difference.
This is a very safe change that has a very minor implication to the output of krane (that most developers don't look at in the first place)