Add block support to rate queue #17
Conversation
kvokka
force-pushed
the
add-block-support-to-rate-queue
branch
2 times, most recently
from
182be19 to
c5eeb06
Compare
|
@sbfaulkner can you please take a look? Thank you |
|
thanks @kvokka -- if you pull the upstream and rebase your changes on that I can look at merging this for a v2.1.0 |
kvokka
force-pushed
the
add-block-support-to-rate-queue
branch
from
c5eeb06 to
cf256da
Compare
|
@sbfaulkner Thank you for the update. I rebased the changes on the current master. Also, FYI, rubocop can not execute, cos https://shopify.github.io/ruby-style-guide/rubocop.yml is not avaliable. |
|
|
||
| mixin = Module.new do | ||
| if RUBY_VERSION < "2.7" |
There was a problem hiding this comment.
since the gem require ruby 2.6+ we can simplify this.
There was a problem hiding this comment.
can we? (ie. since 2.6 is still < 2.7)
There was a problem hiding this comment.
I think my testing showed that wouldn't work on 2.6
There was a problem hiding this comment.
Ruby 2.7 has deprecated automatic conversion from a hash to keyword arguments.
We do not need to worry about 2.6 here, cos the syntax is valid for 2.0+
There was a problem hiding this comment.
yeah... I get that... I just thought I'd tested on 2.6 and needed to handle differently... I may be misremembering :-)
There was a problem hiding this comment.
Np, just for sure i installed Ruby 2.6.3 locally and checked - everything is ok.
But in the process of this check was revealed that travisci just does not work on the repo. Just letting you know
|
Sorry @sbfaulkner , forgot to re-request the review. |
|
@sbfaulkner ping |
Thank you for great gem!
RateQueueclass, which allow to use this gem with custom metrics.Also:
Close #16