feat: Simple load balanced rate control #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great feature and hope it will be merged! |
|
Just rebased branch and removed rubocop upgrades (b/c out of scope for the pull request) Let me know if there is anything I need to do to get this accepted! Cheers! |
By introducing the option `balanced: true` we interleave the initial ring w/ the interval divided by size so all calls will have some air between each call e.g. a simple load balancing. --- By default all calls to the `limit_method` will be bursted, e.g. as quick as possible, until the rate is exceeded. Then we wait for the remainder of the interval to continue. To even out the burst, an optional `balanced` parameter can be provided to enable interleaving between the method calls, e.g: `interleave = interval / size`. ``` ruby ... limit_method :tick, rate: 60, balanced: true ... ``` For example: with an interval of 60 seconds and a rate of 60: `balanced: false` As quickly as possible we call the method 60 times, then we wait for the remainder of the time. `balanced: true` We interleave each call with 1 second so we call this method every second. --- Considerations before merging this PR: - Use `interleaved` instead of `balanced` as an option name - Make the interleave configurable: e.g. instead of `true/false` provide an `float/integer` (which also favours renaming to `interleave`) - ditch this PR because when this is an issue your rate/interval is wrong.
|
Rebased on master and forced pushed. Would love to know if this has any chance of merging or otherwise I will close this PR |
|
@sbfaulkner Can you share a light on this please? |
|
seems reasonable... I'll try to get to full review later today |
|
thanks... should be published as v2.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing the option
balanced: truewe interleave the initial ring w/ the interval divided by size so all calls will have some air between each call e.g. a simple load balancing.By default all calls to the
limit_methodwill be bursted, e.g. as quick as possible, until the rate is exceeded.Then we wait for the remainder of the interval to continue. To even out the burst, an optional
balancedparameter can beprovided to enable interleaving between the method calls, e.g:
interleave = interval / size.For example: with an interval of 60 seconds and a rate of 60:
balanced: falseAs quickly as possible we call the method 60 times, then we wait for the remainder of the time.balanced: trueWe interleave each call with 1 second so we call this method every second.Also fixed in this PR:
Considerations before merging this PR:
interleavedinstead ofbalancedas an option nametrue/falseprovidean
float/integer(which also favours renaming tointerleave)