Update lax mode error-handling specs to match Liquid behavior #111
+40
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maaarcocr
force-pushed
the
marco-template-name-handling
branch
from
6c2fcd1 to
fb768a7
Compare
Liquid handles lax mode errors differently than returning empty strings: - Division/modulo by zero returns descriptive error messages - Float division by zero returns "Infinity" (IEEE 754 standard) - Invalid filter arguments return type error messages - Unknown tags produce parse errors rather than raw text output Also: - Add LongString class registry for generating test strings - Fix very_long_string_filter spec that used broken template syntax
Maaarcocr
force-pushed
the
marco-fix-lax-tests
branch
from
b9089d5 to
95cb2ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquid handles lax mode errors differently than returning empty strings:
Also: