Migrate shopify-code-scanner to pull from Artifact Registry #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## TL;DR You're currently pulling shopify-code-scanner from GCR, which is going away soon. This PR migrates that reference over to Artifact Registry. --- <h4>Why is this being asked?</h4> Please check that this PR makes sense, and merge when ready. It should have zero impact. For further information, please check the issues on your repository. You should have received an issue detailing what's going on. You can also consult the FAQ here: https://github.com/Shopify/gar-migration/blob/main/docs/Artifact_Registry_migration_FAQ.md <h4>What will happen if it doesn't get done within the expected timeframe?</h4> Code scanner will cease to work, preventing your app from building <h4>When does it need to get done?</h4> At the latest, this should be done before <strong>28 Feb 2025.</strong> <h4>I don’t think this action item applies to my service. What do I do?</h4> If you believe this action item is not relevant to your `Service`, you can mark it as not applicable by updating the status of the action item instance to **Not applicable** in Services DB. Visit the [action item instance](https://services.shopify.io/action-items/instances/80814?editStatus=true) and click the **Not applicable** button. Make sure to leave a comment with the reason. If you change your mind, you can update the status with a reason by navigating to the Action Item Instance page in Services DB. This will reopen the action item instance and the GitHub issue. <h4>I have questions/concerns about this</h4> Please contact the **core-commerce-infra** team using #proj-gcr-ar-migration. **Your target**: [liquid-spec](https://services.shopify.io/services/liquid-spec) **Action Item**: https://services.shopify.io/action-items/instances/80814?editStatus=false **Owners**: @Shopify/core-storefronts-storefront-platform-planetary-scale-storefronts, @Shopify/liquid-perf, @Shopify/liquid-perf, @Shopify/storefront-platform, @Shopify/storefront-platform-graphql
alexcoco
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate shopify-code-scanner to pull from Artifact Registry
TL;DR
You're currently pulling shopify-code-scanner from GCR, which is going away soon. This PR migrates that reference over to Artifact Registry.
Why is this being asked?
Please check that this PR makes sense, and merge when ready. It should have zero impact.For further information, please check the issues on your repository. You should have received an issue detailing what's going on. You can also consult the FAQ here: https://github.com/Shopify/gar-migration/blob/main/docs/Artifact_Registry_migration_FAQ.md
What will happen if it doesn't get done within the expected timeframe?
Code scanner will cease to work, preventing your app from buildingWhen does it need to get done?
At the latest, this should be done before 28 Feb 2025.I don’t think this action item applies to my service. What do I do?
If you believe this action item is not relevant to your
Service, you can mark it as not applicable by updating the status of the action item instance to Not applicable in Services DB. Visit the action item instance and click the Not applicable button. Make sure to leave a comment with the reason.If you change your mind, you can update the status with a reason by navigating to the Action Item Instance page in Services DB. This will reopen the action item instance and the GitHub issue.
I have questions/concerns about this
Please contact the core-commerce-infra team using #proj-gcr-ar-migration.
Your target: liquid-spec
Action Item: https://services.shopify.io/action-items/instances/80814?editStatus=false
Owners: @Shopify/core-storefronts-storefront-platform-planetary-scale-storefronts, @Shopify/liquid-perf, @Shopify/liquid-perf, @Shopify/storefront-platform, @Shopify/storefront-platform-graphql