Simplify adapter API and add basics test suite #96
+1,929
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Context wrapper class from adapter_dsl - Pass assigns and options directly to render block - Move deep_copy and register building to runner - Update example adapters to use new API - Update README documentation
The basics suite covers fundamental Liquid features from the official documentation at https://shopify.github.io/liquid/. Every implementation should pass these tests. Features covered: - Raw text output - Object output ({{ }}) - Whitespace control ({{- -}}) - Variable assignment (assign, capture) - Filters (50+ filters with examples) - Conditionals (if/elsif/else/unless) - Case/when statements - For loops with forloop object - Increment/decrement - Comments (block and inline) - Raw tag - Echo and liquid tags - Property access (dot and bracket notation) - Truthy/falsy evaluation - Cycle and tablerow Each spec includes extensive hints explaining how the feature should be implemented, making this suite ideal for new Liquid implementations. The basics suite runs first (before other suites) and has no required features, ensuring all implementations can run it.
- Add 'complexity' field to Unit struct and YAML source loading - Sort specs by complexity within each suite (lower = simpler) - Specs without complexity run last (infinity sort value) - Add complexity values to all 183 basics specs Complexity scale: 10-20: Raw text, literals (no parsing logic) 30-40: Variables, basic filters 50-60: Assign, simple conditionals 70-80: For loops, filter chains 90-100: Complex control flow, capture 110-130: Special tags (increment, comments, liquid) 150-170: Property access, truthy/falsy edge cases 180-200: Advanced features, edge cases This ensures new Liquid implementations can work through specs in order of increasing difficulty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(template, ctx)to(template, assigns, options)Changes
API Simplification
LiquidSpec.render { |template, ctx| }toLiquidSpec.render { |template, assigns, options| }Contextwrapper class - data is now passed directlyBasics Test Suite
Complexity Feature
complexityfield on specs (optional)Other