Add per-spec required_features support #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for individual specs to declare
required_features, allowing them to be skipped when the adapter doesn't support those features.Changes
required_featuresfield toUnitstructrunnable_with?andmissing_featuresmethods toUnitrequired_featuresin the runnershopify_error_handlingfeature for Shopify-specific error behaviortest_subcontext_enter_failstoerror_handling.ymlwithrequired_features: [shopify_error_handling]Why
The
test_subcontext_enter_fails_and_leaves_runtime_in_good_statetest expects specific Shopify-internal error behavior (Liquid error (line 2): internal) that differs from the open source implementation. The open source Liquid correctly renders the template, but Shopify's internal version uses a custom context class that forces errors.By adding per-spec
required_features, we can skip this test for adapters that don't implement Shopify's internal error handling while still running it for Shopify's internal implementation.Example usage in YAML