Add Shopify adapter and mark Dawn suite as non-default #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add liquid_ruby_shopify.rb adapter that stubs Shopify-specific tags and filters (schema, style, form, section, etc.) to enable testing with the open-source Liquid gem. Mark shopify_theme_dawn suite as non-default since these specs: - Were recorded from Shopify's production Liquid implementation - Require Shopify-internal features (dynamic render, specific CDN URLs) - Have incomplete environment data (missing settings values) The adapter successfully runs: - All basics, liquid_ruby, and liquid_ruby_lax specs - 2335/2337 shopify_production_recordings specs (2 use internal test drops)
When -s specifies a specific suite (not :all), run that suite even if it's not marked as default. This allows running shopify_theme_dawn explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
liquid_ruby_shopify.rbadapter that stubs Shopify-specific tags and filtersshopify_theme_dawnsuite as non-defaultShopify Adapter
The new adapter registers stubs for Shopify-specific Liquid extensions:
Tags:
{% schema %}- outputs nothing (stores JSON schema){% style %}- outputs<style>tag{% javascript %}- outputs nothing{% form %}- outputs basic form tag{% paginate %}- passes through content{% section %},{% sections %},{% layout %}- output nothingFilters:
tasset_url,image_url,img_url,shopify_asset_url, etc.money,money_with_currency, etc.color_to_rgb,color_brightness, etc.Schema Defaults:
The adapter extracts
{% schema %}JSON from templates and applies default settings values to section/block data.Test Results
The 2 failures use Shopify-internal test drops (
NotSafeStringDrop) that test HTML safety behavior specific to Shopify's implementation.Dawn Suite Changes
Marked as
default: falsebecause these specs:{% render %}syntax)The Dawn specs are kept as reference for Shopify's internal testing infrastructure.