Fix loading all Tasks with namespace collision #939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from Rails 7 to 7.1, we started seeing an error when trying to load the Maintenance Task UI:
We ended up identifying the BasicObject as PRIMARY_KEY_NOT_SET, which was added to Active Record in 7.1. The reason for attempting to load this constant was that we have a model in our app named Maintenance which inherits from ActiveRecord::Base, and so all of the constants below ActiveRecord::Base get loaded by load_constants. (This clearly isn't a common case, nor something I would recommend other applications do).
To fix this, we can use the Rails application's loader to load all of the application's tasks instead of traversing the constant tree. This approach has multiple benefits:
Since
#eager_load_namespace
was introduced in Zeitwerk 2.6.2 but the minimum required by Rails is 2.6, the higher minimum version was added to the gemspec as well.