Fix shipping rate invalidation bug using Apple Pay in 1.2.2 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d invalidat the already set (through a updateCheckout: call) shippingRate on a checkout during completeCheckout:
|
Reviewed, and tested. 🚢 |
runmad
added a commit
that referenced
this pull request
Dec 2, 2015
…shipping-rates Fix shipping rate invalidation bug using Apple Pay in 1.2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Fix #68
This fixes an issue where the
partialAddressesflag was set to false, which would invalidate the already set (through aupdateCheckout:completion:call) shippingRate on Shopify during a call tocompleteCheckout:completion:.I have added more context to the usage of the
partialAddressesproperty and we now override the setter to throw anNSExceptionif this is ever set tofalse. This value should always ever be set totrue.I have removed the code that would have (and may have) set this property to
falseand added a test assertion that an exception is thrown if the value is set.@davidmuzi please review 👀