Updated API endpoints #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en made using NSURLComponents. Tests have been updated to better match testing of the scheme, host, path and query items from which a NSURLComponents URL is created.
|
Looks fine. 🎩 |
runmad
added a commit
that referenced
this pull request
Dec 9, 2015
…-add-url-components Updated API endpoints
runmad
deleted the
chore/runmad.update-checkouts-api-add-url-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR primarily switches
/anywhere/checkoutsto the new/api/checkoutsendpoint. However, I thought it was a good chance to switch over to usingNSURLComponentsto create all of the request URLs with, which consisted of some work to use the paths and query items that comes with it./anywhere/checkouts->/api/checkoutsNSURLComponentsto create request URLsNSURLfor better consistency@bgulanowski please review 👀 and 🎩