Remove deprecation notice and raise error when strings cannot be parsed by bigdecimal #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #307
Why
Currently we attempt to parse strings with BigDecimal, and we default to
BigDecimal(0)
for cases where the string cannot be parsed. In v3, we want to remove this fallback and we recommend users to parse the money first before using initializing a new money object.What
This is a breaking change
We now raise ArgumentError if the provided value is a string and cannot be parsed by BigDecimal.