Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Faraday::Connection#authorization' deprecation warning #56

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

tomekchime
Copy link
Contributor

Fixes a the Faraday deprecation warning:

WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:authorization, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.

The solution was taken from this oktokit PR octokit/octokit.rb#1359. Specifically the change to this file

https://github.com/octokit/octokit.rb/pull/1359/files#diff-049c21c25599adc0dd5306bf783df23cd13a20af81ffee0a7bc9bc44b62907e2

@ghost ghost added the cla-needed label Apr 28, 2022
@tomekchime
Copy link
Contributor Author

CLA submitted

@ghost ghost removed the cla-needed label Jun 23, 2022
@matt-mcmurray-shopify
Copy link

This looks good to me. I'd like to get it merged, just checking in with the team first. Thanks @tomekchime 🎉

@ltk
Copy link
Member

ltk commented Jun 30, 2022

LGTM. I'll merge and then cut a new release shortly.

@ltk ltk merged commit 3b8c73f into Shopify:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants