Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deleting old deprecated_references files #317

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

gmcgibbon
Copy link
Member

What are you trying to accomplish?

Stop deleting old reference files for the next release.

What approach did you choose and why?

Since 3.0 is released, this is no longer needed. Everyone should be using package_todo files now. We're removing this because mainly because it is less file IO is faster.

What should reviewers focus on?

Does this make sense?

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

Since 3.0 is released, this is no longer needed. Everyone should be
using package_todo files now. We're removing this because mainly because
it is less file IO is faster.
@gmcgibbon gmcgibbon requested a review from a team as a code owner March 1, 2023 21:03
@gmcgibbon gmcgibbon merged commit 5fdf6c7 into main Mar 2, 2023
@gmcgibbon gmcgibbon deleted the stop_deleting_deprecated_references branch March 2, 2023 18:05
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems March 9, 2023 00:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants