Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect deleted files as stale violations #332

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Detect deleted files as stale violations #332

merged 6 commits into from
Mar 21, 2023

Commits on Mar 13, 2023

  1. Type PackageTodo entries

    @gmcgibbon
    gmcgibbon committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e70bdd4 View commit details
    Browse the repository at this point in the history

  2. Improve OffenseCollection#stale_violations? test accuracy

    @gmcgibbon
    gmcgibbon committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    31529e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Refactor PackageTodo#stale_violations? 

    Breaking it up into private methods for easier readability.
    @gmcgibbon
    gmcgibbon committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d3576d5 View commit details
    Browse the repository at this point in the history

  2. Detect deleted files as stale violations 

    Also rename todo_list to old_entries (to contrast with new_entries),
drop Type postfix from TODO entry types, and remove extra file entry
from test/fixtures/package_todo.yml to make an existing stale check test
pass.
    @gmcgibbon
    gmcgibbon committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    ecf165b View commit details
    Browse the repository at this point in the history

  3. Make a private reader for @new_entries

    @gmcgibbon
    gmcgibbon committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    efa1a2a View commit details
    Browse the repository at this point in the history

  4. Simplify path handling in PackageTodo

    @gmcgibbon
    gmcgibbon committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    664b2f5 View commit details
    Browse the repository at this point in the history