Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom offenses formatter docs fix #394

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Custom offenses formatter docs fix #394

merged 1 commit into from
Mar 8, 2024

Conversation

timjnh
Copy link
Contributor

@timjnh timjnh commented Mar 7, 2024

What are you trying to accomplish?

Fix the docs! More specifically a broken link in them

What approach did you choose and why?

I updated the URL to what looked like the correct destination. Why? I just felt like it was the right thing to do.

What should reviewers focus on?

The link to the DefaultOffensesFormatter in the Custom Offenses Formatter section

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

@timjnh timjnh requested a review from a team as a code owner March 7, 2024 18:59
@timjnh
Copy link
Contributor Author

timjnh commented Mar 7, 2024

Signed the CLA but couldn't see a way to retrigger...

Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmcgibbon gmcgibbon merged commit f52fb63 into Shopify:main Mar 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants