Skip to content

Commit 5f97080

Browse files
authored
[Button] Remove connectedDisclosure (#10182)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes #10126 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes all code related to connectedDisclosure Updates the split example to use Popover, ActionList, and ButtonGroup
1 parent 008508a commit 5f97080

38 files changed

+113
-457
lines changed

.changeset/honest-stingrays-act.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris': major
3+
---
4+
5+
Removed connectedDislosure prop on button

documentation/guides/migrating-from-v11-to-v12.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,5 @@ Secondary, becomes oneThird:
5353
`npx @shopify/polaris-migrator react-rename-component <path> --renameFrom="HorizontalGrid" --renameTo="InlineGrid" --renamePropsFrom="HorizontalGridProps" --renamePropsTo="InlineGridProps"`
5454

5555
**Button**
56-
// TODO
56+
57+
- connectedDisclosure: [See the updated split example](https://polaris.shopify.com/components/actions/button)

polaris-react/locales/cs.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Zavřít notifikaci"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Načítání",
34-
"connectedDisclosureAccessibilityLabel": "Související akce"
33+
"spinnerAccessibilityLabel": "Načítání"
3534
},
3635
"Common": {
3736
"checkbox": "zaškrtávací pole",

polaris-react/locales/da.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Afvis meddelelse"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Indlæser",
34-
"connectedDisclosureAccessibilityLabel": "Relaterede handlinger"
33+
"spinnerAccessibilityLabel": "Indlæser"
3534
},
3635
"Common": {
3736
"checkbox": "afkrydsningsfelt",

polaris-react/locales/de.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Benachrichtigung verwerfen"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Wird geladen",
34-
"connectedDisclosureAccessibilityLabel": "Ähnliche Aktionen"
33+
"spinnerAccessibilityLabel": "Wird geladen"
3534
},
3635
"Common": {
3736
"checkbox": "Kontrollkästchen",

polaris-react/locales/en.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@
3838
"dismissButton": "Dismiss notification"
3939
},
4040
"Button": {
41-
"spinnerAccessibilityLabel": "Loading",
42-
"connectedDisclosureAccessibilityLabel": "Related actions"
41+
"spinnerAccessibilityLabel": "Loading"
4342
},
4443
"Common": {
4544
"checkbox": "checkbox",

polaris-react/locales/es.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Descartar notificación"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Cargando",
34-
"connectedDisclosureAccessibilityLabel": "Acciones relacionadas"
33+
"spinnerAccessibilityLabel": "Cargando"
3534
},
3635
"Common": {
3736
"checkbox": "casilla de verificación",

polaris-react/locales/fi.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Ohita ilmoitus"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Ladataan",
34-
"connectedDisclosureAccessibilityLabel": "Aiheeseen liittyvät toimenpiteet"
33+
"spinnerAccessibilityLabel": "Ladataan"
3534
},
3635
"Common": {
3736
"checkbox": "valintaruutu",

polaris-react/locales/fr.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Rejeter la notification"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Chargement en cours",
34-
"connectedDisclosureAccessibilityLabel": "Actions associées"
33+
"spinnerAccessibilityLabel": "Chargement en cours"
3534
},
3635
"Common": {
3736
"checkbox": "case à cocher",

polaris-react/locales/it.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@
3030
"dismissButton": "Elimina notifica"
3131
},
3232
"Button": {
33-
"spinnerAccessibilityLabel": "Caricamento in corso",
34-
"connectedDisclosureAccessibilityLabel": "Azioni correlate"
33+
"spinnerAccessibilityLabel": "Caricamento in corso"
3534
},
3635
"Common": {
3736
"checkbox": "casella di spunta",

0 commit comments

Comments
 (0)