[polaris.shopify.com] Fix Modal examples #10541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
approved these changes
Sep 18, 2023
Contributor
sophschneider
left a comment
sophschneider
left a comment
There was a problem hiding this comment.
Do these examples have an provider we could just add Frame to ?
kyledurand
force-pushed
the
fix-modal-examples
branch
from
9986906 to
41c7ae0
Compare
Member
Author
That's what I was looking for initially but there were a couple problems. 1 the import failed, I couldn't access polaris components from the app.tsx file. Then I couldn't confirm that it would actually fix the problem when I grabbed it from the build folder because the examples were rendering for me locally. This should be a surefire way to make sure the examples get rendered |
sam-b-rose
approved these changes
Sep 18, 2023
Member
sam-b-rose
left a comment
sam-b-rose
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, Kyle!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.