-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove nav level rule #10568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nav level rule #10568
Conversation
| @@ -8,6 +8,13 @@ | |||
| "rollupButton": "View actions" | |||
| } | |||
| }, | |||
| "ActionList": { | |||
| "SearchField": { | |||
| "clearButtonLabel": "Clear", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Clearfor keyPolaris.ActionList.SearchField.clearButtonLabelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "ActionList": { | ||
| "SearchField": { | ||
| "clearButtonLabel": "Clear", | ||
| "search": "Search", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Searchfor keyPolaris.ActionList.SearchField.searchis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "SearchField": { | ||
| "clearButtonLabel": "Clear", | ||
| "search": "Search", | ||
| "placeholder": "Search actions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Search actionsfor keyPolaris.ActionList.SearchField.placeholderis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
Remove the max level rule in the Frame nav and use the `hideChildren` boolean in frontmatter
Remove the max level rule in the Frame nav and use the
hideChildrenboolean in frontmatter