-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Revert "Executing useBreakpoints isormophically no longer triggers a Hydration mismatch error or rendering bugs."
#10916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Hydration mismatch error or rendering bugs." This reverts commit d2518f2.
laurkim
approved these changes
Oct 6, 2023
aaronccasanova
added a commit
that referenced
this pull request
Oct 6, 2023
#10918) …riggers a Hydration mismatch error or rendering bugs." (#10916)" This reverts #10916 to reapply #10886 cc @jesstelford
Contributor
|
Why's that? The bug exists on |
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
…a Hydration mismatch error or rendering bugs." (#10916) Reverts #10886 Moving this change to the `next` branch cc @jesstelford
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
#10918) …riggers a Hydration mismatch error or rendering bugs." (#10916)" This reverts #10916 to reapply #10886 cc @jesstelford
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
…a Hydration mismatch error or rendering bugs." (#10916) Reverts #10886 Moving this change to the `next` branch cc @jesstelford
mrcthms
pushed a commit
that referenced
this pull request
Oct 12, 2023
#10918) …riggers a Hydration mismatch error or rendering bugs." (#10916)" This reverts #10916 to reapply #10886 cc @jesstelford
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…a Hydration mismatch error or rendering bugs." (Shopify#10916) Reverts Shopify#10886 Moving this change to the `next` branch cc @jesstelford
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
Shopify#10918) …riggers a Hydration mismatch error or rendering bugs." (Shopify#10916)" This reverts Shopify#10916 to reapply Shopify#10886 cc @jesstelford
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10886
Moving this change to the
nextbranch cc @jesstelford