[v4] Update React - preparations #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
commented
May 1, 2019
| @@ -1,5 +0,0 @@ | |||
| // https://github.com/Microsoft/TypeScript/issues/24599 | |||
| declare module 'prop-types' { | |||
There was a problem hiding this comment.
This was causing namespace issues
AndrewMusgrave
commented
May 1, 2019
| import {polarisAppProviderContextTypes} from '../types'; | ||
| import AppProvider from '../AppProvider'; | ||
|
|
||
| describe('<AppProvider />', () => { | ||
| it('passes i18n and withComponent properties to context', () => { |
There was a problem hiding this comment.
This test will be updated and improved when we switch AppProvider to the new context API
AndrewMusgrave
commented
May 1, 2019
| @@ -312,18 +312,20 @@ describe('<Modal>', () => { | |||
| }); | |||
|
|
|||
| describe('with app bridge', () => { | |||
| let AppBridgeModalCreate: jest.SpyInstance; | |||
There was a problem hiding this comment.
The next few files are using jest API to spy on functions rather than overwrite the function with a spy
AndrewMusgrave
added
the
🤖Skip Changelog
alex-page
approved these changes
May 1, 2019
AndrewMusgrave
force-pushed
the
update-react
branch
from
6a6b6a8 to
862a709
Compare
Add types to test until Remove polaris context namespace Remove frame namespace Export createContext result Small quaility change Rename context wrapper Update themeprovider namespace Add type Add theme context to util Update type name for app provider context Update test utility and revert tsconfig changee
Convert ScrollTo Remove dropzone context from index Convert navigation Convert combobox Convert withincontext Update frame context Update resourcelist context Update themeprovider context Update appprovider context Touchups changelog Update appprovider context type Rename file
Update context
[v4] Add usePolaris/AppBridge
[AppProvider] Update context
Remove testID warning
|
@danrosenthal I was planning on merging this into |
No need, was just adding us there so we could follow along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Unfortunately we cannot continue updating our react components to prepare for react 16.8.* until we update to 16.8.* 😅 Enzyme doesn't support the new context at our current version, a bump in the version require a bump in other packages require a bump in react
WHAT is this pull request doing?
Updating react / enzyme