[v4] Switch react-transition-group versions #1759
Conversation
AndrewMusgrave
changed the base branch from
version-4.0.0
to
rm-css-transition-pool
AndrewMusgrave
changed the base branch from
rm-css-transition-pool
to
version-4.0.0
AndrewMusgrave
added
the
🤖Skip Changelog
| @@ -0,0 +1,21 @@ | |||
| declare module '@material-ui/react-transition-group' { | |||
There was a problem hiding this comment.
Why did we need to declare this module? Is it because the fork didn't include the types?
There was a problem hiding this comment.
Every package we consume needs types, however, most don't include them in the package. Polaris does include types, which is why we don't have a @types/shopify__polaris-react. react-transition-group does have a types package, which we're still consuming and I'm using to create type definitions for @material-ui/react-transition-group which doesn't have a @types package
| @@ -124,6 +124,10 @@ $bulk-actions-offset-slide-in-start: rem(-40px); | |||
| } | |||
| } | |||
|
|
|||
| .CheckableContainer { | |||
| flex: 1 1 0; | |||
There was a problem hiding this comment.
Why was this needed? I see.
| @@ -151,15 +151,13 @@ export function polarisContextReactWrapper<P, S>( | |||
| } | |||
|
|
|||
| return ( | |||
| <React.StrictMode> | |||
There was a problem hiding this comment.
Why did you remove Strictmode, wasn't this the reason for this PR?
There was a problem hiding this comment.
Enzyme still uses it 😢 Although @shopify/react-testing and storybook don't 😄
WHY are these changes introduced?
Some of our dependencies use
findDOMNodewhich is a strict mode nono 😭findDOMNodefindDOMNodeWHAT is this pull request doing?
findDOMNodeHow to 🎩
Check out animations in the deployment (Frame, Toast, Modal, Dialog, ReosurceList, and Sheet)
Notes
CSSTransitionfromPopoverOverlayreact-transition-groupto suggest an alternative tofindDOMNodebut I'm not sure they'll accept the change since it's an api change and this doesn't seem like a priority