Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade typescript to 3.7.2 (#2237)" #2501

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

dleroux
Copy link
Contributor

@dleroux dleroux commented Dec 4, 2019

This reverts commit 9085064.
#2237

Microsoft has commited a breaking change in a minor release of typescript
microsoft/TypeScript#33939

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2019

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified9
Files potentially affected1

Details

All files potentially affected (total: 1)
📄 package.json (total: 0)

Files potentially affected (total: 0)

🧩 src/components/ContextualSaveBar/ContextualSaveBar.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/DropZone/tests/DropZone.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/RangeSlider/RangeSlider.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/RangeSlider/components/DualThumb/tests/DualThumb.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/ThemeProvider/ThemeProvider.tsx (total: 1)

Files potentially affected (total: 1)

🧩 src/components/Toast/Toast.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/tests/is-element-in-viewport.test.ts (total: 0)

Files potentially affected (total: 0)

📄 yarn.lock (total: 0)

Files potentially affected (total: 0)


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@dleroux dleroux added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Dec 4, 2019
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dleroux dleroux merged commit c2a3275 into master Dec 4, 2019
@dleroux dleroux deleted the revert-ts-update branch December 4, 2019 16:09
@dleroux dleroux temporarily deployed to production December 4, 2019 16:23 Inactive
@BPScott BPScott mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants