Skip to content

Conversation

@vwassan
Copy link

@vwassan vwassan commented Jun 12, 2025

Part 1 of https://github.com/Shopify/semantic-query-engine/issues/428

@vwassan vwassan marked this pull request as ready for review June 12, 2025 23:33
case <-done:
// All connections closed gracefully
return nil
case <-time.After(1 * time.Second):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to the stdlib convention. See the docs for Close() vs Shutdown():

https://pkg.go.dev/net/http#Server.Close
https://pkg.go.dev/net/http#Server.Shutdown

Because Shutdown() accepts a ctx argument that allows the integrator to set the timeout. The way this code is structured there is no way to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants