better server tests

packages/react-cookie/src/CookieUniversalProvider.tsx

@@ -13,13 +13,14 @@ const NO_MANAGER_ERROR = [
 
 export interface Props {
   children?: React.ReactNode;
+  server?: boolean;
 }
 
-export function CookieUniversalProvider({children}: Props) {
+export function CookieUniversalProvider({server, children}: Props) {
   const manager = useNetworkManager();
 
   const cookieManager = useLazyRef(() => {
-    if (hasDocumentCookie()) {
+    if (!server && hasDocumentCookie()) {
       return new BrowserCookieManager();
     }
 

packages/react-cookie/src/index.ts

@@ -10,3 +10,4 @@ export {
 } from './types';
 
 export {clearCookies, createCookies} from './tests/utilities';
+export {hasDocumentCookie} from './utilities';

packages/react-server/src/server/test/server.test.tsx

@@ -1,10 +1,6 @@
 import React from 'react';
 import {useTitle} from '@shopify/react-html';
-import {
-  useCookie,
-  createCookies,
-  CookieUniversalProvider,
-} from '@shopify/react-cookie';
+import {useCookie, CookieUniversalProvider} from '@shopify/react-cookie';
 import {createServer} from '../server';
 
 import {mockMiddleware, TestRack} from '../../test/utilities';
@@ -71,18 +67,22 @@ describe('createServer()', () => {
       return <>{cookieValue}</>;
     }
 
-    createCookies({foo: {value: 'bar'}});
-
-    const wrapper = await rack.mount(({ip, port}) =>
-      createServer({
-        port,
-        ip,
-        render: () => (
-          <CookieUniversalProvider>
-            <MockApp />
-          </CookieUniversalProvider>
-        ),
-      }),
+    const wrapper = await rack.mount(
+      ({ip, port}) =>
+        createServer({
+          port,
+          ip,
+          render: () => (
+            <CookieUniversalProvider server>
+              <MockApp />
+            </CookieUniversalProvider>
+          ),
+        }),
+      {
+        headers: {
+          cookie: `${cookie}=${value}`,
+        },
+      },
     );
 
     const response = await wrapper.request();

packages/react-server/src/test/utilities.ts

@@ -11,15 +11,18 @@ export class TestRack {
     this.servers.forEach(server => server.close());
   }
 
-  async mount(mountFunction: ({port: number, ip: string}) => Server) {
+  async mount(
+    mountFunction: ({port: number, ip: string}) => Server,
+    options: RequestInit = {},
+  ) {
     const port = await getPort();
     const ip = 'http://localhost';
     const server = mountFunction({port, ip});
 
     this.servers.push(server);
 
     return {
-      request: () => fetch(`${ip}:${port}`).then(response => response),
+      request: () => fetch(`${ip}:${port}`, options).then(response => response),
     };
   }
 }