spread is too slow (when compiled to es5)

Shopify · Apr 1, 2021 · 56b6bf3 · 56b6bf3
1 parent 8453341
commit 56b6bf3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/react-testing/src/element.ts b/packages/react-testing/src/element.ts
@@ -256,12 +256,14 @@ function equalSubset(subset: object, full: object) {
   );
 }
 
-function getDescendants(element) {
+function getDescendants(element: any) {
   const descendants: Element<unknown>[] = [];
   // eslint-disable-next-line @typescript-eslint/prefer-for-of
   for (let i = 0; i < element.elementChildren.length; i++) {
     const child = element.elementChildren[i];
-    descendants.push(child, ...getDescendants(child));
+    descendants.push(child);
+    // eslint-disable-next-line prefer-spread
+    descendants.push.apply(descendants, child.elementDescendants);
   }
 
   return descendants;