Merge pull request #2161 from Shopify/chore/no-extra-seed

[graphql-fixtures] Remove unused call to faker.seed()
Shopify · Feb 14, 2022 · d90818d · d90818d
2 parents 4ed0b20 + 948bf62
commit d90818d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/graphql-fixtures/CHANGELOG.md b/packages/graphql-fixtures/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Removes call to `faker.seed()` that uses `Math.random()` as a seed value [[#2161]](https://github.com/Shopify/quilt/pull/2161)
 
 ## 1.4.1 - 2022-02-09
 

diff --git a/packages/graphql-fixtures/src/fill.ts b/packages/graphql-fixtures/src/fill.ts
@@ -299,9 +299,7 @@ function withRandom<T>(keypath: FieldDetails[], func: () => T, seedOffset = 0) {
       ),
     ) + seedOffset,
   );
-  const value = func();
-  faker.seed(Math.random() * 10000);
-  return value;
+  return func();
 }
 
 function createValue<T>(