Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Commit

Permalink
Update @shopify/eslint-plugin
Browse files Browse the repository at this point in the history
Remove linting of graphql files. The only graphql files in the repo are
fixture files which were ignored. Thus there is no point in having a
lint ruleset that lints graphql files.
  • Loading branch information
BPScott committed Jun 29, 2022
1 parent 879f400 commit e5f8a3e
Show file tree
Hide file tree
Showing 7 changed files with 120 additions and 432 deletions.
6 changes: 6 additions & 0 deletions .changeset/large-spoons-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/react-compose': patch
'@shopify/react-form-state': patch
---

Adding ignore comments to satisfy updated eslint configs
5 changes: 0 additions & 5 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,5 @@ packages/*/build
**/*.mjs
**/tests/fixtures/**/default-types/*.ts

# Don't lint fixture graphql files as they include schemas
packages/graphql-config-utilities/src/tests/fixtures/**/*.graphql
packages/graphql-typescript-definitions/tests/fixtures/**/*.graphql
packages/graphql-validate-fixtures/tests/fixtures/**/*.graphql

# Don't lint storybook-a11y-fixtures
packages/storybook-a11y-test/tests/fixtures/storybook
6 changes: 4 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module.exports = {
'plugin:@shopify/typescript',
'plugin:@shopify/typescript-type-checking',
'plugin:@shopify/react',
'plugin:@shopify/graphql',
'plugin:@shopify/jest',
'plugin:@shopify/prettier',
],
Expand Down Expand Up @@ -93,12 +92,15 @@ module.exports = {
},
},
{
files: ['**/tests/fixtures/**/*.*'],
files: ['**/tests/fixtures/**/*'],
rules: {
'@shopify/typescript/prefer-pascal-case-enums': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-unnecessary-qualifier': 'off',
'babel/object-curly-spacing': 'off',
'prettier/prettier': 'off',
'import/newline-after-import': 'off',
'import/order': 'off',
},
},
{
Expand Down
5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@shopify/app-bridge": "^2.0.3",
"@shopify/babel-preset": "^24.1.4",
"@shopify/browserslist-config": "^3.0.0",
"@shopify/eslint-plugin": "^41.1.0",
"@shopify/eslint-plugin": "^42.0.1",
"@shopify/loom": "^1.0.1",
"@shopify/loom-cli": "^1.0.1",
"@shopify/loom-plugin-build-library": "^1.0.2",
Expand Down Expand Up @@ -77,8 +77,5 @@
"tsd": "^0.19.1",
"typescript": "^4.3.5",
"yalc": "^1.0.0-pre.50"
},
"resolutions": {
"cross-fetch": "3.1.5"
}
}
3 changes: 3 additions & 0 deletions packages/react-compose/src/tests/compose.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,17 @@ describe('react-compose-enhancers', () => {
});

interface FooProps {
// eslint-disable-next-line react/no-unused-prop-types
foo: string;
}

interface BarProps {
// eslint-disable-next-line react/no-unused-prop-types
bar: string;
}

interface Props {
// eslint-disable-next-line react/no-unused-prop-types
baz: string;
}

Expand Down
1 change: 1 addition & 0 deletions packages/react-form-state/src/FormState.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ interface Props<Fields> {
validators?: Partial<ValidatorDictionary<Fields>>;
onSubmit?: SubmitHandler<Fields>;
validateOnSubmit?: boolean;
// eslint-disable-next-line react/no-unused-prop-types
onInitialValuesChange?: 'reset-all' | 'reset-where-changed' | 'ignore';
externalErrors?: RemoteError[];
}
Expand Down
Loading

0 comments on commit e5f8a3e

Please sign in to comment.