Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
BPScott committed Apr 9, 2021
1 parent 7008ade commit fbccf2c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 2 additions & 0 deletions templates/package.hbs.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"description": "{{{description}}}",
"main": "index.js",
"types": "index.d.ts",
"scripts": {},
"sideEffects": false,
"publishConfig": {
"access": "public",
Expand All @@ -20,6 +21,7 @@
"url": "https://github.com/Shopify/quilt/issues"
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/{{name}}/README.md",
"dependencies": {},
"files": [
"build/*",
"!*.tsbuildinfo",
Expand Down
8 changes: 0 additions & 8 deletions tests/consistent-package-json.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ packages.forEach(
it('specifies Quilt Issues as bugs URL', () => {
expect(packageJSON.bugs).toStrictEqual(expectedPackageJSON.bugs);
});
it('specifies dependencies', () => {
expect(packageJSON.dependencies).not.toStrictEqual({});
});
it('specifies a description', () => {
expect(packageJSON.description).not.toBeUndefined();
});
Expand Down Expand Up @@ -102,11 +99,6 @@ packages.forEach(
expectedPackageJSON.repository,
);
});
it('specifies scripts, including build', () => {
expect(packageJSON.scripts.build).toBe(
expectedPackageJSON.scripts.build,
);
});
it('specifies if webpack can tree-shake, via sideEffects', () => {
expect(packageJSON.sideEffects).toBe(
Boolean(packageJSON.sideEffects),
Expand Down

0 comments on commit fbccf2c

Please sign in to comment.