You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Related to #519, the recent fix #531 fixed the issue for lists a single level deep. However, if there's a FormState.List within a FormState.List, the component crashes when an item is added to the nested list, because initialValue is undefined instead of an empty array.
I believe adding an additional guard of initialValue || before intialValue[index] to line 49 of List.tsx will solve this issue and it seems to work with local testing, but I do not know the package well enough to thoroughly test for unintended side-effects.
Consuming repo
Shopify/quilt
Checklist
Please delete the labels section before submitting your issue
I have described this issue in a way that is actionable (if possible)
The text was updated successfully, but these errors were encountered:
Overview
Related to #519, the recent fix #531 fixed the issue for lists a single level deep. However, if there's a
FormState.List
within aFormState.List
, the component crashes when an item is added to the nested list, becauseinitialValue
isundefined
instead of an empty array.I believe adding an additional guard of
initialValue ||
beforeintialValue[index]
to line 49 ofList.tsx
will solve this issue and it seems to work with local testing, but I do not know the package well enough to thoroughly test for unintended side-effects.Consuming repo
Shopify/quilt
Checklist
The text was updated successfully, but these errors were encountered: