This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix react-form-state List component #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TzviPM
reviewed
Feb 26, 2019
marina101
force-pushed
the
fix-form-state-list
branch
2 times, most recently
from
c0e6746 to
11a2706
Compare
axelerator
approved these changes
Feb 26, 2019
Introduced in this commit: https://github.com/Shopify/quilt/pull/475/files#diff-68157ac38fbcaa003b546774b1857293R48 on line 48. The bug is that initialValue[index][fieldPath] throws an exception instead of returning undefined the way it previously did when initialValue[index] is undefined. I added an extra check to see if initialValue.index is defined and return undefined if its not.
marina101
force-pushed
the
fix-form-state-list
branch
from
11a2706 to
9534b2a
Compare
TzviPM
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Looks great @marina101; thanks so much for pushing these changes through :)
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #519
This is a fix for a regression that was introduced in this commit: https://github.com/Shopify/quilt/pull/475/files#diff-68157ac38fbcaa003b546774b1857293R48 on line 48. The bug is that initialValue[index][fieldPath] throws an exception instead of returning undefined the way it previously did when initialValue[index] is undefined. I added an extra check to see if initialValue.index is defined and return undefined if its not.
🎩 it with our form (which has a polymorphic list and uses the List from react-form-state) and now it working instead of throwing an error (relates to #11012).