Current code break react hook rules

[michenly]

Overview

https://github.com/Shopify/quilt/blob/master/packages/react-graphql/src/hooks/query.ts#L41-L43

The above code break react hook rules and need to be corrected.

This bug was introduced in #726 and the fix should contain two parts investigations.

1. Figure out why the react-hooks linter did not break when this was introduced

2. The fix should not have early return but also does not attempt to resolve an async GraphQL document on the server when skip.

Consuming repo

What repo were you working in when this issue occurred?

Shopify/web

Labels

• Add the Type: Bug label to this issue.

Area

• Add any relevant Area: <area> labels to this issue

Scope

• Is this issue related to a specific package?

  • Tag it with the Package: <package_name> label.

---

Checklist

• Please delete the labels section before submitting your issue
• I have described this issue in a way that is actionable (if possible)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.