This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix cache-less queries in SSR #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michenly
suggested changes
Jul 2, 2019
| @@ -38,12 +38,16 @@ export default function useQuery< | |||
| } = options; | |||
| const client = useApolloClient(overrideClient); | |||
|
|
|||
| if (typeof window === 'undefined' && skip) { | |||
| if ((typeof window === 'undefined' && skip) || fetchPolicy === 'no-cache') { | |||
There was a problem hiding this comment.
this early return actually breaks react hook rule. Is there anyway not to do this anymore?
There was a problem hiding this comment.
The rules of hooks don't matter for server rendering. They only exist so that a single component, when updated, calls hooks in the same order, but in server renders, the entire component is thrown out each time.
There was a problem hiding this comment.
that make sense to me, so this is really a dev experience thing to for consumer of this package to understand why they would be getting this warning.
lemonmade
force-pushed
the
fix-network-only-ssr
branch
from
bf591d9 to
db6378b
Compare
GoodForOneFare
approved these changes
Jul 4, 2019
michenly
approved these changes
Jul 4, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two types of
fetchPoliciesthat ignore the cache:network-onlyandno-cache. We aren't currently handling either of them well: AFAICT, in both cases queries lead to infinite looping while trying to resolve during SSR, because the client will make a fresh query every time. This PR is a stab at addressing them that I think makes sense. In the case ofnetwork-only, we can transform it to becache-firstin SSR, so that it will save to cache and re-use for all subsequent server renders.no-cachehas a promise about not putting stuff in the cache, so for those, I've updated the code to consider them equivalent toskipped queries.cc/ @rox163 while I was playing with this locally, it reduced the number of render loops needed for products pages to just 3 (one for the first set of queries, one for the queries rendered by the product show page, and one last one where it finds no more queries to resolve).