This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Use outerHTML for html() on DOM nodes #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We noticed that this PR either modifies or introduces usage of the dangerouslySetInnerHTML attribute, which can cause cross-site scripting (XSS) vulnerabilities. Our team will take a look soon, but for now we recommend reviewing your code to ensure that this is what you intended to use and that there is not a safe alternative available. Docs are available here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #802. This PR fixes an issue where we would omit the outermost DOM elements when calling
html()on a tree.Type of change
Checklist
cc/ @TheVedhaGuy, this fixes one of the issues you raised. The other one (
Attempted to operate on a mounted tree, but the component is no longer mounted) I think is actually a problem with your component. That error usually happens when some part of the component throws an error, which forcesreact-testingto unmount the tree. We have a test that verifies the behaviour of components nested in fragments, so I am pretty confident that part works correctly.