This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
♻️ have withTiming return early if performance.timing does not ex…
#1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michenly
force-pushed
the
add-check-to-performance
branch
2 times, most recently
from
b1f8423 to
1550544
Compare
michenly
commented
Oct 15, 2019
GoodForOneFare
approved these changes
Oct 15, 2019
michenly
force-pushed
the
add-check-to-performance
branch
5 times, most recently
from
1440d7d to
7d8e512
Compare
|
actually changed the way I solved this. It feels less hacky now. |
lemonmade
approved these changes
Oct 16, 2019
michenly
force-pushed
the
add-check-to-performance
branch
from
7d8e512 to
9989181
Compare
…ist. Co-Authored-By: Gord P <GoodForOneFare@users.noreply.github.com>
michenly
force-pushed
the
add-check-to-performance
branch
from
9989181 to
78e273f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ist.
Description
The performance mock currently return an empty object which mean calling
new Performancewill run into error during test.I feel like I am not getting to the root of the issue with this solution.
Musing 1:
I think the performance mock come with jsdom, which only mock a portion of the API in
performancebut this does not explain why the mock is an empty object.Musing 2:
we are using
performance.timing, but checking forPerformanceNavigationTimingbefore use. Should we check forPerformanceTimingas well?Musing 3:
PerformanceTimingis deprecated 😂, should the code be updated to useperformance.navigationinstead? Although the official types havetimingandnavigationtype listed as deprecatedType of change
Checklist