This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Loosen statsd-instruments dependency in quilt_rails #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodoretan
force-pushed
the
loosen-statsd-dependency
branch
2 times, most recently
from
8d46fa2 to
58cd632
Compare
theodoretan
commented
Nov 22, 2019
| @@ -2,7 +2,11 @@ | |||
|
|
|||
| require_relative 'boot' | |||
|
|
|||
| require 'rails/all' | |||
There was a problem hiding this comment.
@TheMallen There was a "ManifestNeeded" error because railties was bumped and the solution was to not use require rails/all
Co-authored-by: Deborah Chan <deborah.chan@shopify.com>
theodoretan
force-pushed
the
loosen-statsd-dependency
branch
from
58cd632 to
e0c6b45
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Deborah Chan deborah.chan@shopify.com
Description
The
~>specifier creates a hard dependency for consuming projects which makes it harder to use the gem if the project has a newer version.https://github.com/Shopify/partners/pull/20598/files#r345427947
Type of change
Use the
>=specifier which will only allow minor version changes.Checklist