This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Export formatDate function #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michenly
reviewed
Feb 18, 2020
4 tasks
helloneele
force-pushed
the
dates-export-formatDate
branch
from
4d4d720 to
4bd303c
Compare
|
@michenly Oh, didn't realize there was documentation in the readme, sorry. Should be good now 🙂 |
michenly
reviewed
Feb 19, 2020
| hour: 'numeric', | ||
| }; | ||
|
|
||
| const newDate = formatDate(date, locales, options); // 9 AM |
There was a problem hiding this comment.
The new date is just 9 AM?
There was a problem hiding this comment.
Yeah, it's based on the options you pass it apparently. By doing hour: 'numeric' it'll just return the hour. If you don't specify hour it'll give you the date like this 2/18/2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This exports the
formatDatefunction so we can reuse it in@shopify/react-i18nand in shopify web directly. This will reduce code duplication and hopefully also eliminate more memory leaks once we use it.I'll put up a follow-up PR for the
@shopify/react-i18npackage that makes use of this function.Follow up PR: #1287
Type of change
Checklist